build: support clang-cl compiler
#169
Merged
+1
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmehala
requested review from
dubloom,
pablomartinezbernardo and
a team
and removed request for
a team
dmehala
force-pushed
the
dmehala/win-xcomp
branch
from
21fbbb2 to
db1eefc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #169 +/- ##
=======================================
Coverage 93.91% 93.91%
=======================================
Files 73 73
Lines 4176 4176
=======================================
Hits 3922 3922
Misses 254 254 ☔ View full report in Codecov by Sentry. |
pablomartinezbernardo
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In another internal project that relies on
dd-trace-cpp, I needed to enable cross-compilation for Windows from a Linux host. During this process, I usedclang-clas the compiler - MSVC frontend forclang. However, I encountered an issue whereCMAKE_CXX_COMPILER_IDwas detected asClang, which caused the incorrect file to be included, leading to a compilation failure.To address this, I utilized the
CMAKE_CXX_COMPILER_FRONTEND_VARIANTvariable. This change ensures that the correct compiler frontend (clang-cl) is identified, allowing for successful cross-compilation in this scenario.